Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] folds in retro and bug fixes made in dev-sci (#551, #558, #561) #567

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

MatthewPyle-NOAA
Copy link
Contributor

DESCRIPTION OF CHANGES:

  • Set of changes made in three separate merges.

TESTS CONDUCTED:

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

  • These changes to dev-sci originally authored by @hu5970

Copy link
Contributor

@BenjaminBlake-NOAA BenjaminBlake-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatthewPyle-NOAA Thanks for doing this!

@MatthewPyle-NOAA
Copy link
Contributor Author

Will wait to see if @hu5970 can confirm that everything looks okay to him before merging.

@MatthewPyle-NOAA
Copy link
Contributor Author

@hu5970 If you have a chance, could you take a quick look at this PR? I manually folded in some of the changes you made on dev-sci into main, but could use fresh eyes to make sure I didn't make a mistake somewhere.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 7ce4516 into NOAA-EMC:main Dec 12, 2024
2 checks passed
@MatthewPyle-NOAA MatthewPyle-NOAA deleted the feature/mingfixes branch December 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants